erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land.
LGTM (after a minor comment), thank you for fixing this! ================ Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:3598 + S = new (Context) BuiltinBitCastExpr( + Empty, /*PathSize*/ Record[ASTStmtReader::NumExprFields]); + break; ---------------- PathSize should always be zero, so I think it makes more sense to `assert(Record[ASTStmtReader::NumExprFields] == 0);` here and remove the PathSize parameter from the BuiltinBitCastExpr constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
