aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109
+ static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) {
+ IO.enumCase(Value, "Warning", clang::tooling::Diagnostic::Warning);
+ IO.enumCase(Value, "Error", clang::tooling::Diagnostic::Error);
----------------
DmitryPolukhin wrote:
> aaron.ballman wrote:
> > Do we have to handle notes as well?
> clang::tooling::Diagnostic::Level supports only 2 levels error and warning:
> https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Tooling/Core/Diagnostic.h#L65
Huh, good to know!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79285/new/
https://reviews.llvm.org/D79285
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
