jdoerfert added inline comments.
================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); + } else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel()); ---------------- This looks pretty much like D81658, right? Could we avoid the duplication and maybe use a templated function (or something else)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81478/new/ https://reviews.llvm.org/D81478 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits