modocache added a reviewer: junparser.
modocache added a subscriber: junparser.
modocache added a comment.
Excellent, thank you! The test failures on the diff appear to be legitimate,
they reproduce for me when I apply this patch to my local checkout and run
`ninja check-clang`. Could you take a look?
This LGTM otherwise! Also adding @junparser in case they have any thoughts, if
not I'll accept after the test failures are addressed, Thanks!
================
Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:1051
+ FT = S.ResolveExceptionSpec(Loc.isInvalid() ? E->getBeginLoc() : Loc, FT);
+ }
if (!FT)
----------------
Small nit-pick: Omit the `{` and `}` here, as that's the convention in the
surrounding lines of this file and in the LLVM project in general.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82029/new/
https://reviews.llvm.org/D82029
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
