[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added inline comments.


================
Comment at: clang-tools-extra/clangd/Preamble.cpp:242
       llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
-      getFileSystem() const override {
+      getFileSystem(llvm::NoneType) const override {
         return VFS;
----------------
A warning here too
```
23:51:14 
/repo/bbiswjenk/fem023-eiffel003/workspace/llvm/sdk_1_20_ki_dev_test/clang-tools-extra/clangd/Preamble.cpp:234:5:
 warning:   by 'virtual llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> 
clang::clangd::{anonymous}::scanPreamble(llvm::StringRef, const 
clang::tooling::CompileCommand&)::EmptyFS::view(llvm::NoneType) const' 
[-Woverloaded-virtual]
23:51:14      view(llvm::NoneType) const override {
23:51:14      ^~~~
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81920/new/

https://reviews.llvm.org/D81920



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits