sammccall added a comment.
Can you update the commit message to also reflect the change in
`cache_directory` behavior? (This is going to move clangd index files on macOS,
for instance... I think that's OK, but let's not bury it)
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3253
+ CmdArgs.push_back(Args.MakeArgString(Path));
+ }
}
----------------
what happens in the else case?
================
Comment at: llvm/lib/Support/Unix/Path.inc:1163
+#ifdef __APPLE__
+ if (getDarwinConfDir(false/*tempDir*/, result)) {
+ return true;
----------------
nit: `/*TempDir=*/false` is conventional and e.g. clang-tidy will verify it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82362/new/
https://reviews.llvm.org/D82362
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
