arsenm added a comment.

In D82249#2107845 <https://reviews.llvm.org/D82249#2107845>, @hctim wrote:

> In D82249#2105036 <https://reviews.llvm.org/D82249#2105036>, @arsenm wrote:
>
> > Is the fallback not working correctly in this case for some reason?
>
>
> I'm fairly sure that G_GLOBAL_VALUE used to fallback onto SelectionDAGISel, 
> and that was changed in D78465 <https://reviews.llvm.org/D78465>. Because we 
> only implemented the custom `adrp+movk` lowering in SelectionDAGISel, making 
> that instruction sequence no longer fallback, so we don't get our proper 
> lowering for HWASan globals.


I don't follow. It no longer falls back, so what is the problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82249/new/

https://reviews.llvm.org/D82249



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to