ymandel added a comment. In D82654#2116906 <https://reviews.llvm.org/D82654#2116906>, @gribozavr2 wrote:
> Any chance for a test? StencilTest.CatOfInvalidRangeFails essentially covers this (indeed, earlier versions of the code failed this test). https://github.com/llvm/llvm-project/blob/master/clang/unittests/Tooling/StencilTest.cpp#L419 I can make it more specific, but since this only affects the error message and not the control flow, I didn't update the test. Let me know if you disagree -- I generally avoid testing error message content in tests, but I know there's a variety of opinions on this subject... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82654/new/ https://reviews.llvm.org/D82654 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
