sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Nice, thank you! ================ Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6278 + return true; + // FIXME(liuhui): Ideally, we should check the ctor parameter list to + // verify whether it is a copy ctor or a move ctor. ---------------- comment: default, copy, and move constructor? ================ Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6285 + auto Op = Id.OperatorFunctionId.Operator; + if (Op == OverloadedOperatorKind::OO_Equal) + return true; ---------------- Maybe a comment like "copy and move assignment" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits