nemanjai accepted this revision.
nemanjai added a comment.

As far as I'm concerned, this is fine for now. We can remove these once all 
in-tree target have implemented their support.
LGTM but maybe give a couple of days for others to chime in.



================
Comment at: clang/lib/Basic/Targets/PPC.h:86
+
+    HasStrictFP = true;
   }
----------------
I don't think we need this for now. Close is not quite there. @steven.zhang I 
would prefer that we initially turn this off and only flip it on once the 
support is complete.
Also, is the support that is currently under development for both 32 and 64 bit 
architectures? If it is 64 bit only, then we can enable it only there once it 
is done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80952/new/

https://reviews.llvm.org/D80952



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to