ckandeler added a comment.

I suppose it boils down to whether the visit() function is supposed to except 
null arguments or not. Since I don't know the answer to that, I added the check 
at the caller. From the description of the linked patch, it appears that other 
places are also calling the function with a null pointer, but that could just 
mean that these should be fixed independently. Someone with better knowledge of 
the code would have to make that decision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82629/new/

https://reviews.llvm.org/D82629



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to