Abpostelnicu added a comment. In D81917#2127690 <https://reviews.llvm.org/D81917#2127690>, @njames93 wrote:
> In D81917#2127477 <https://reviews.llvm.org/D81917#2127477>, @Abpostelnicu > wrote: > > > @njames93 wdyt if we add another parameter to distinguish if we want to use > > regex or not, and if not we escape the paths? > > Also thank you so much for catching this up! > > > As the argument is documented as being a regex string, we shouldn't really > try to escape it, and users should be expected escape any file names > themselves before invoking the script. > If for whatever reason you want to use `.c++` as your file extension. then > you should pass `r'*\.c\+\+'` to the script. > > Can I ask what the specific use case you have that is causing the issue? Are > you invoking `run-clang-tidy` from a script that generates the list of files > to search for? Thank you for the detailed reply! we are using this script in automation and some files from our repo indeed need to be escaped. I think it makes sense what you are saying to give to the consumer the files already escaped. I'm going to close this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81917/new/ https://reviews.llvm.org/D81917 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
