MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments.
================ Comment at: clang/unittests/Format/FormatTest.cpp:13540 CHECK_PARSE_BOOL(AlignConsecutiveMacros); + CHECK_PARSE_BOOL(AlwaysBreakBeforeConceptDeclarations); CHECK_PARSE_BOOL(AllowAllArgumentsOnNextLine); ---------------- curdeius wrote: > MyDeveloperDay wrote: > > curdeius wrote: > > > Format: leading whitespace. Should it be in the same "group" as > > > `AlignConsecutiveMacros`? > > I might be misunderstanding your comment, but the list should alphabetic > > but now I realize it should be after the `Allows` > I just wanted to point out that when you don't put a blank line after > CHECK_PARSE_BOOL, then the next one gets indented. And yes, the order isn't > ok. BTW, us "Always" in the name necessary? Cf. other "Break" options. @curdeius I didn't get to make changes to match your previous review comments yet, but I 100% agree with you why did I put Always here! I WILL remove that as I can see further down the road if this got changed to an enumeration it would be ``` AlwaysBreakBeforeConceptDeclarations = Always AlwaysBreakBeforeConceptDeclarations = Sometimes AlwaysBreakBeforeConceptDeclarations = Never ``` Which would be very confusing... I'll address those concerns next CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
