djtodoro marked 2 inline comments as done. djtodoro added inline comments.
================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: ---------------- vsk wrote: > Please factor out OptCustomPassManager from opt and generalize it so it can > be used by both opt and clang. That should help ensure that extensions and > bug fixes are only made to one custom 'debugify' pass manager. I'll try that with the latest code. I remember I've tried it once, but I ended up moving it into the IR library (since we need to link it within legacy pass manager). ================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:893 + + void enableDebugifyEachOriginal() { DebugifyEachOriginalEnabled = true; } + ---------------- vsk wrote: > I don't think the discussion from 'RFC: Introduce LLVM DI Checker utility' is > complete, and I'd ask that you split off changes for 'original mode' from > this patch until there's some consensus about what that mode should look like. > > There are open questions about to what extent a new mode is needed (e.g., it > may be that the interesting questions compiler developers need to answer > about debug info loss are simpler to determine some other way (which is not > to say that that's true -- just that we haven't explored the space much > yet)). Or what its output should look like. OK, I'll split off this and notify you/resend a message on the RFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits