ahatanak added a comment. This looks good to me.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:11825 + Expr *TrueExpr = E->getTrueExpr(); + if (isa<BinaryConditionalOperator>(E)) ---------------- Can you use `BinaryConditionalOperator::getCommon` here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81751/new/ https://reviews.llvm.org/D81751 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits