MaskRay marked 6 inline comments as done. MaskRay added inline comments.
================ Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { - fprintf(stderr, "unable to find __gcov_flush in func.shared': %s\n", dlerror()); + void (*gcov_reset1)() = (void (*)())dlsym(f1_handle, "__gcov_reset"); + if (gcov_reset1 == NULL) { ---------------- serge-sans-paille wrote: > Do we also need to test gcov_flush symbol here too? `__gcov_flush` is deleted. We don't need to test it. ================ Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c.gcov:56 +// CHECK-NEXT: 1: 50: if (gcov_reset1 == NULL) { +// CHECK-NEXT: #####: 51: fprintf(stderr, "unable to find __gcov_reset in func.shared': %s\n", dlerror()); // CHECK-NEXT: #####: 52: return EXIT_FAILURE; ---------------- serge-sans-paille wrote: > Same question here, what about gcov_flush symbol? `__gcov_flush` is deleted. We don't need to test it. ================ Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main_three-libs.c.gcov:55 +// CHECK-NEXT: 1: 49: void (*gcov_reset1)() = (void (*)())dlsym(f1_handle, "__gcov_reset"); +// CHECK-NEXT: 1: 50: if (gcov_reset1 == NULL) { +// CHECK-NEXT: #####: 51: fprintf(stderr, "unable to find __gcov_reset in func.shared': %s\n", dlerror()); ---------------- serge-sans-paille wrote: > And here. `__gcov_flush` is deleted. We don't need to test it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits