SjoerdMeijer added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:118
+
+ if (!llvm::AArch64::getArchFeatures(ArchKind, Features))
+ return false;
----------------
Would it be more consistent to move this....
================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:273
const auto ItRFP16FML = std::find(Features.rbegin(), Features.rend(),
"+fp16fml");
if (llvm::is_contained(Features, "+v8.4a")) {
const auto ItRFullFP16 = std::find(Features.rbegin(), Features.rend(),
"+fullfp16");
----------------
...to somewhere here where implied target features are handled....
================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:373
}
if (Arg *A = Args.getLastArg(options::OPT_mno_unaligned_access,
----------------
For example, to here.
================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:115
+// RUN: %clang -target aarch64-none-linux-gnu -march=armv8.6-a+sve -x c -E -dM
%s -o - | FileCheck --check-prefix=CHECK-SVE-8_6 %s
+// CHECK-SVE-8_6: __ARM_FEATURE_SVE 1
----------------
Can you add a run line for v8.5 if there isn't already one, and add CHECK-NOTs
for these macros.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83079/new/
https://reviews.llvm.org/D83079
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
