cchen marked an inline comment as done.
cchen added inline comments.
================
Comment at: clang/lib/Parse/ParseExpr.cpp:1933
}
+ if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) {
+ // Consume ':'
----------------
ABataev wrote:
> You need to insert an additional check for `OMPClauseKind ==
> llvm::omp::Clause::OMPC_to || OMPClauseKind == llvm::omp::Clause::OMPC_from`
> here. I.e. we shall expect stride not only if the version is 5.0, but also if
> the current clauses is `to` or `from`
Got it, I was thinking that we might want to emit diagnostic message for OpenMP
version < 50. Thanks for your explaination.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82800/new/
https://reviews.llvm.org/D82800
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
