clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just test for paths and this will be good to go!
================
Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:35
+ self.assertEqual(program_basename, program_module['name'])
+ self.assertIn('path', program_module, 'make sure path is in module')
+ self.assertTrue('symbolFilePath' not in program_module, 'Make sure
a.out.stripped has no debug info')
----------------
add a check for the path:
```
self.assertEqual(program, program_module['path'])
```
================
Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:42
+ program_module = active_modules[program_basename]
+ self.assertEqual(program_basename, program_module['name'])
+ self.assertEqual('Symbols loaded.', program_module['symbolStatus'])
----------------
check 'path' again here.
================
Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:47
+ self.assertIn('addressRange', program_module)
\ No newline at end of file
----------------
add a newline
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82477/new/
https://reviews.llvm.org/D82477
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
