hokein added inline comments.
================ Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType ---------------- sammccall wrote: > here we're splitting the type (e.g. int&&) into a type + VK, and passing both > to createrecoveryexpr. > > Why not do that on recoveryexpr side? e.g. if we request a recoveryexpr of > type int&, return an LValue recoveryexpr of type int? right, good idea, this is simpler. I was somehow taking `CallExpr` as a reference when writing this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/ https://reviews.llvm.org/D83201 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits