eduucaldas marked 2 inline comments as done. eduucaldas added inline comments.
================ Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1265 + | |-UserDefinedLiteralExpression + | | `-12_w + | `-; ---------------- gribozavr2 wrote: > It looks somewhat weird to me that integer and floating point literals end up > with the same syntax tree node type. WDYT about making different nodes for > different literals (integer, floating-point, string, character)? Makes sense. Let's follow the [[ https://eel.is/c++draft/lex.ext#nt:user-defined-literal | grammar ]] then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits