hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1208
+ // "first (inherited) member".
+ HandledFirstNonOverlappingEmptyField = true;
+
----------------
We need some sort of `IsFirstNonEmptyBase` to record that the current base
qualifies for the alignment upgrade:
```
struct A { double x; };
struct B : A {} b;
```
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1245
+ // space or zero-extent array.
+ if (DefaultsToAIXPowerAlignment && HandledFirstNonOverlappingEmptyField) {
+ UnpackedPreferredBaseAlign = UnpackedBaseAlign;
----------------
Query `!IsFirstNonEmptyBase` instead of `HandledFirstNonOverlappingEmptyField`
here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79719/new/
https://reviews.llvm.org/D79719
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
