kbobyrev marked an inline comment as done.
kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:64
+ if (ParsedURI->scheme() != "file") {
+ elog("Can not parse URI with scheme other than \"file\" {0}", URI);
+ return llvm::None;
----------------
sammccall wrote:
> I think it's fine to fold this into the previous check: "bad URI" covers it
But it has different message :( `ParsedURI.takeError` wouldn't make sense here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82938/new/
https://reviews.llvm.org/D82938
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
