ArcsinX created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
Build log:
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp: In member
function ‘virtual void
clang::clangd::{anonymous}::PreamblePatchTest_Define_Test::TestBody()’:
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:267:3:
error: could not convert ‘(const char*)"\012 #define BAR\012
[[BAR]]"’ from ‘const char*’ to ‘llvm::StringLitera ’
};
^
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:267:3:
error: could not convert ‘(const char*)"#line 0 \".*main.cpp\"\012#line
2\012#define BAR\012"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:267:3:
error: could not convert ‘(const char*)"\012 #define BAR \\\012\012
[[BAR]]"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:267:3:
error: could not convert ‘(const char*)"#line 0 \".*main.cpp\"\012#line
2\012#define BAR\012"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:267:3:
error: could not convert ‘(const char*)"\012 #define \\\012
BAR\012 [[BAR]]"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:267:3:
error: could not convert ‘(const char*)"#line 0 \".*main.cpp\"\012#line
3\012#define BAR\012"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp: In member
function ‘virtual void
clang::clangd::{anonymous}::PreamblePatchTest_LocateMacroAtWorks_Test::TestBody()’:
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
};
^
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)"\012 #define $def^FOO\012
$use^FOO"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)"\012 #define $def^FOO\012
#undef $use^FOO"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)"\012 #define $def^FOO\012
#undef FOO\012 $use^FOO"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)"\012 #define \\\012
$def^FOO\012 $use^FOO"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)"\012 #\\\012
define /* FOO */\\\012 /* FOO */ $def^FOO\012
$use^FOO"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)"#define FOO"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:357:3:
error: could not convert ‘(const char*)"\012 #define BAR\012
#define $def^FOO\012 $use^FOO"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp: In member
function ‘virtual void
clang::clangd::{anonymous}::PreamblePatchTest_RefsToMacros_Test::TestBody()’:
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:445:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
};
^
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:445:3:
error: could not convert ‘(const char*)"\012 #define ^FOO\012
^[[FOO]]"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:445:3:
error: could not convert ‘(const char*)"#define FOO"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:445:3:
error: could not convert ‘(const char*)"\012 #define BAR\012
#define ^FOO\012 ^[[FOO]]"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:445:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:445:3:
error: could not convert ‘(const char*)"\012 #define ^FOO\012
#undef ^FOO"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp: In member
function ‘virtual void
clang::clangd::{anonymous}::PreamblePatch_ModifiedBounds_Test::TestBody()’:
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:512:3:
error: could not convert ‘(const char*)""’ from ‘const char*’ to
‘llvm::StringLiteral’
};
^
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:512:3:
error: could not convert ‘(const char*)"\012 #define FOO\012
FOO"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:512:3:
error: could not convert ‘(const char*)"#define FOO"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:512:3:
error: could not convert ‘(const char*)"#define BAR"’ from ‘const char*’ to
‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:512:3:
error: could not convert ‘(const char*)"\012 #define FOO\012
#undef FOO"’ from ‘const char*’ to ‘llvm::StringLiteral’
llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp:512:3:
error: could not convert ‘(const char*)"#define FOO"’ from ‘const char*’ to
‘llvm::StringLiteral’
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D83548
Files:
clang-tools-extra/clangd/unittests/PreambleTests.cpp
Index: clang-tools-extra/clangd/unittests/PreambleTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/PreambleTests.cpp
+++ clang-tools-extra/clangd/unittests/PreambleTests.cpp
@@ -230,8 +230,8 @@
TEST(PreamblePatchTest, Define) {
// BAR should be defined while parsing the AST.
struct {
- llvm::StringLiteral Contents;
- llvm::StringLiteral ExpectedPatch;
+ const char *const Contents;
+ const char *const ExpectedPatch;
} Cases[] = {
{
R"cpp(
@@ -270,7 +270,7 @@
SCOPED_TRACE(Case.Contents);
Annotations Modified(Case.Contents);
EXPECT_THAT(getPreamblePatch("", Modified.code()),
- MatchesRegex(Case.ExpectedPatch.str()));
+ MatchesRegex(Case.ExpectedPatch));
auto AST = createPatchedAST("", Modified.code());
ASSERT_TRUE(AST);
@@ -304,8 +304,8 @@
TEST(PreamblePatchTest, LocateMacroAtWorks) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Addition of new directive
{
@@ -417,8 +417,8 @@
TEST(PreamblePatchTest, RefsToMacros) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Newly added
{
@@ -491,8 +491,8 @@
TEST(PreamblePatch, ModifiedBounds) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Size increased
{
Index: clang-tools-extra/clangd/unittests/PreambleTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/PreambleTests.cpp
+++ clang-tools-extra/clangd/unittests/PreambleTests.cpp
@@ -230,8 +230,8 @@
TEST(PreamblePatchTest, Define) {
// BAR should be defined while parsing the AST.
struct {
- llvm::StringLiteral Contents;
- llvm::StringLiteral ExpectedPatch;
+ const char *const Contents;
+ const char *const ExpectedPatch;
} Cases[] = {
{
R"cpp(
@@ -270,7 +270,7 @@
SCOPED_TRACE(Case.Contents);
Annotations Modified(Case.Contents);
EXPECT_THAT(getPreamblePatch("", Modified.code()),
- MatchesRegex(Case.ExpectedPatch.str()));
+ MatchesRegex(Case.ExpectedPatch));
auto AST = createPatchedAST("", Modified.code());
ASSERT_TRUE(AST);
@@ -304,8 +304,8 @@
TEST(PreamblePatchTest, LocateMacroAtWorks) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Addition of new directive
{
@@ -417,8 +417,8 @@
TEST(PreamblePatchTest, RefsToMacros) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Newly added
{
@@ -491,8 +491,8 @@
TEST(PreamblePatch, ModifiedBounds) {
struct {
- llvm::StringLiteral Baseline;
- llvm::StringLiteral Modified;
+ const char *const Baseline;
+ const char *const Modified;
} Cases[] = {
// Size increased
{
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
