Szelethus accepted this revision. Szelethus marked 2 inline comments as done. Szelethus added a comment. This revision is now accepted and ready to land.
LGTM! Very well done! In D67420#2149461 <https://reviews.llvm.org/D67420#2149461>, @vsavchenko wrote: > I strongly believe that decoupling (when done right) makes things easier and > this change seems like a good first step. This patch I think categorizes, rather. We could do a much better job at that with these options, I agree, if we switched over to TableGen (D83475#inline-768468 <https://reviews.llvm.org/D83475#inline-768468>). The problem is, its hard to justify the engineering hours for an arguably negligible gain. ================ Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:47-48 + + void printBugPath(llvm::raw_ostream &o, const FIDMap &FM, + const PathPieces &Path); + ---------------- Nice. ================ Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:39-42 - const bool IncludePath = false; - const bool ShouldEmitAsError = false; - const bool ApplyFixIts = false; - const bool ShouldDisplayCheckerName = false; ---------------- Really nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/ https://reviews.llvm.org/D67420 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
