steven_wu created this revision. steven_wu added reviewers: zixuw, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang.
-fembed-bitcode options doesn't embed warning options since they are useless to code generation. Make sure it handles the W_value group and not embed those options in the output. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83813 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/Frontend/embed-bitcode.ll Index: clang/test/Frontend/embed-bitcode.ll =================================================================== --- clang/test/Frontend/embed-bitcode.ll +++ clang/test/Frontend/embed-bitcode.ll @@ -37,6 +37,11 @@ ; CHECK: @llvm.cmdline = private constant ; CHECK: section "__LLVM,__cmdline" +; check warning options are not embedded +; RUN: %clang_cc1 -triple thumbv7-apple-ios8.0.0 -emit-llvm \ +; RUN: -fembed-bitcode=all -x ir %s -o - -Wall -Wundef-prefix=TEST \ +; RUN: | FileCheck %s -check-prefix=CHECK-WARNING + ; CHECK-ELF: @llvm.embedded.module ; CHECK-ELF: section ".llvmbc" ; CHECK-ELF: @llvm.cmdline @@ -54,6 +59,9 @@ ; CHECK-MARKER: @llvm.cmdline ; CHECK-MARKER: section "__LLVM,__cmdline" +; CHECK-WARNING-NOT: Wall +; CHECK-WARNING-NOT: Wundef-prefix + define i32 @f0() { ret i32 0 } Index: clang/lib/Frontend/CompilerInvocation.cpp =================================================================== --- clang/lib/Frontend/CompilerInvocation.cpp +++ clang/lib/Frontend/CompilerInvocation.cpp @@ -1087,7 +1087,9 @@ A->getOption().getID() == options::OPT_x || A->getOption().getID() == options::OPT_fembed_bitcode || (A->getOption().getGroup().isValid() && - A->getOption().getGroup().getID() == options::OPT_W_Group)) + A->getOption().getGroup().getID() == options::OPT_W_Group) || + (A->getOption().getGroup().isValid() && + A->getOption().getGroup().getID() == options::OPT_W_value_Group)) continue; ArgStringList ASL; A->render(Args, ASL);
Index: clang/test/Frontend/embed-bitcode.ll =================================================================== --- clang/test/Frontend/embed-bitcode.ll +++ clang/test/Frontend/embed-bitcode.ll @@ -37,6 +37,11 @@ ; CHECK: @llvm.cmdline = private constant ; CHECK: section "__LLVM,__cmdline" +; check warning options are not embedded +; RUN: %clang_cc1 -triple thumbv7-apple-ios8.0.0 -emit-llvm \ +; RUN: -fembed-bitcode=all -x ir %s -o - -Wall -Wundef-prefix=TEST \ +; RUN: | FileCheck %s -check-prefix=CHECK-WARNING + ; CHECK-ELF: @llvm.embedded.module ; CHECK-ELF: section ".llvmbc" ; CHECK-ELF: @llvm.cmdline @@ -54,6 +59,9 @@ ; CHECK-MARKER: @llvm.cmdline ; CHECK-MARKER: section "__LLVM,__cmdline" +; CHECK-WARNING-NOT: Wall +; CHECK-WARNING-NOT: Wundef-prefix + define i32 @f0() { ret i32 0 } Index: clang/lib/Frontend/CompilerInvocation.cpp =================================================================== --- clang/lib/Frontend/CompilerInvocation.cpp +++ clang/lib/Frontend/CompilerInvocation.cpp @@ -1087,7 +1087,9 @@ A->getOption().getID() == options::OPT_x || A->getOption().getID() == options::OPT_fembed_bitcode || (A->getOption().getGroup().isValid() && - A->getOption().getGroup().getID() == options::OPT_W_Group)) + A->getOption().getGroup().getID() == options::OPT_W_Group) || + (A->getOption().getGroup().isValid() && + A->getOption().getGroup().getID() == options::OPT_W_value_Group)) continue; ArgStringList ASL; A->render(Args, ASL);
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits