c-rhodes marked 5 inline comments as done. c-rhodes added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenTypes.h:138 + llvm::Type *ConvertTypeForMem(QualType T, bool ForBitField = false, + bool EnforceFixedLengthSVEAttribute = false); ---------------- efriedma wrote: > The default for EnforceFixedLengthSVEAttribute seems backwards; I would > expect that almost everywhere that calls ConvertTypeForMem actually wants the > fixed-length type. The scalable type only exists in registers. > The default for EnforceFixedLengthSVEAttribute seems backwards; I would > expect that almost everywhere that calls ConvertTypeForMem actually wants the > fixed-length type. The scalable type only exists in registers. It has no effect unless `T->isVLST()` so I think it makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83553/new/ https://reviews.llvm.org/D83553 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
