v.g.vassilev removed a reviewer: aaron.ballman.
v.g.vassilev added a comment.



>> Also, I would like to add that the current test present in this diff does 
>> not fail in the existing system but it was the best I and Vassil could come 
>> up with to replicate our problem.
> 
> Is there a way to run something like creduce to come up with a test case that 
> does replicate the issue? I'd like to ensure we have a test case that fails 
> without the patch applied so that we can be sure we don't regress the 
> behavior.

Not easily. That bug comes from internal infrastructure which uses clang's API 
and happens when calling directly the mangler. Running creduce would require 
failure to be reproducible with bare clang. I was hoping @rsmith had something 
up his sleeve.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83174/new/

https://reviews.llvm.org/D83174



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to