hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land.
LGTM w/ nit ================ Comment at: clang/lib/Driver/SanitizerArgs.cpp:1091 + if (Sanitizers.has(SanitizerKind::FuzzerNoLink)) { + CmdArgs.push_back("-fno-builtin-memcmp"); ---------------- Nit - add a comment here mentioning the libfuzzer interceptors, and that other sanitizers normally do this by propagating IR attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits