logan-5 added a comment. In D84244#2167625 <https://reviews.llvm.org/D84244#2167625>, @hans wrote:
> I don't really know why this doesn't happen with other warning flags, but I > think it would be better to add flags like this with add_compile_options > rather than add_compile_definitions. I imagine that would prevent it from > reaching rc.exe. That sounds pretty reasonable. Without any way of testing the Windows setup myself though, I don't feel comfortable making that change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84244/new/ https://reviews.llvm.org/D84244 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
