hans added inline comments.
================ Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:702 } + if (RemoteIndexAddress.empty() != ProjectPath.empty()) { + llvm::errs() << "remote-index-address and project-path have to be " ---------------- hokein wrote: > the new code section here should be guarded under `#ifdef > CLANGD_ENABLE_REMOTE` I think it should be an #if since the macro is always defined (0 or 1). Doing that in 40d11a878044711708fb6738e4b78a4c9ac3de7b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits