mtrofin added inline comments.
================ Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// ---------------- kazu wrote: > mtrofin wrote: > > I'd clarify that transferring the data from pre-link thinlto to post-link > > isn't supported, but one could use this in post-link, correct? > We don't add DumpAccumulator to the post-link ThinLTO pipeline yet. > > Note that we add DumpAccumulator in buildPerModuleDefaultPipeline, but > post-link ThinLTO doesn't call the function. > Yes - my point is that one could enable it in post-link and 'it'd just work'; the thing that doesn't work is making pre-link data jump over to post-link, which would require more plumbing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
