gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h:76 + /// Stores the style options for a given directory. + mutable llvm::StringMap<std::vector<llvm::Optional<NamingStyle>>> + NamingStylesCache; ---------------- And could you please document what the indices for the vector are? ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-multiple-styles.cpp:7 + +// C++11 isnt explicitly required, but failing to specify a standard means the +// check will run multiple times for different standards. This will cause the ---------------- "isn't" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84814/new/ https://reviews.llvm.org/D84814 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
