rsmith added a comment. In D84637#2175681 <https://reviews.llvm.org/D84637#2175681>, @erichkeane wrote:
> Based on richard's suggestions, that seems about right. However I believe > all the asserts should have a message to go along with them as we typicaly do. In this case, the asserts are enforcing AST invariants, so I think they're OK without diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
