NoQ added a comment. Generally i think this is shaping up nicely, with the couple of minor nits addressed i'm happy to land this. Like, there are a few cornercases that we could address but we could do that in follow-up patches. Folks, do you see anything else here?
================ Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:131 + } + return nullptr; +} ---------------- You never ever check for this case. Therefore this function entirely boils down to `Call.getArgExpr(0)` which is shorter than `getFirstArgExpr(Call)` anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84600/new/ https://reviews.llvm.org/D84600 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
