nridge marked an inline comment as done. nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305 + break; + default:; + } ---------------- nridge wrote: > hokein wrote: > > nit: move the trailing `;` to a new line. > I have done this, but clang-format moves it back... do we really want to > fight wit it? I wrote it as: ``` default: break; ``` instead, I think that may be more idiomatic anyways. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85272/new/ https://reviews.llvm.org/D85272 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits