sberg added inline comments.
Herald added a subscriber: dang.

================
Comment at: clang/include/clang/Driver/Options.td:1778
+  HelpText<"Enable stack clash protection">;
+def fnostack_clash_protection : Flag<["-"], "fnostack-clash-protection">, 
Group<f_Group>,
+  HelpText<"Disable stack clash protection">;
----------------
Should this rather spell `"fno-stack-clash-protection"`?  The above change to 
clang/docs/ClangCommandLineReference.rst (but which got overwritten by 
<https://github.com/llvm/llvm-project/commit/9624beb38a46037f69362650a52e06d8be4fd006>
 "[docs] Regenerate ClangCommandLineReference.rst") mentions 
`-fno-stack-clash-protection`, and also GCC calls it like that.  (Though the 
below clang/test/Driver/stack-clash-protection.c does use 
`-fnostack-clash-protection`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68720/new/

https://reviews.llvm.org/D68720

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to