xazax.hun added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/DynamicType.cpp:73 + Ty = STTPTy->getReplacementType(); + if (Ty->isPointerType()) + Ty = Ty->getPointeeType(); ---------------- Is this doing what you intended? What about a reference to a pointer? Wouldn't you do too much unboxing? Also, I think a function returning a value would be more conventional. Other sugars like typedefs cannot interfere? I think this patch might benefit from additional test coverage. I also see no tests for template substitutions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85752/new/ https://reviews.llvm.org/D85752 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
