erichkeane added a comment. In D74361#1927931 <https://reviews.llvm.org/D74361#1927931>, @JonChesterfield wrote:
> In D74361#1927863 <https://reviews.llvm.org/D74361#1927863>, @thakis wrote: > >> This breaks tests on Windows: http://45.33.8.238/win/10664/step_7.txt >> >> Please take a look, and if it takes some time please revert while you >> investigate. > > Thanks! It seems Windows inserts 'dso_local' into the middle of the generated > IR. > > I can't test on Windows so the two that failed CI are now marked as > "UNSUPPORTED: system-windows". > > Do you know a usual work around for variation in symbol visibility? I'm happy > to copy it from another test but am wary of guessing what might work on > Windows. Our windows builds always just add dso_local, so we typically just do a wildcard there to handle those cases (or, separate check lines for windows). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
