vrnithinkumar added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/CheckerManager.cpp:682
         anyEvaluated = true;
+        Dst.clear();
         Dst.insert(checkDst);
----------------
> runCheckersForEvalCall() already has its own builder, you don't need another.

In that case is it okay to clear the  `ExplodedNodeSet DstEvaluated` passed as 
`Dst` which contains parent node [[ 
https://github.com/llvm/llvm-project/blob/master/clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp#L604
 | contains parent node ]] ?

When the any of the evaluated checker is evaluated the node successfully we can 
clear the `Dst` which is part of the `StmtNodeBuilder Bldr(DstPreCall, 
DstEvaluated, *currBldrCtx);` before inserting new nodes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85796/new/

https://reviews.llvm.org/D85796

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to