bruno added a comment. Hi Zixu, thanks for working on improving this.
I agree with @vsapsai on the the `GenModuleActionWrapper` approach. Also, it seems to me that even though it would somehow improve the accuracy, it would be solving a more general problem, not really specific to this patch. What about `CHECK`s for the introduced fix-its? I don't see a `#include` or `#import` being matched in the tests. ================ Comment at: clang/lib/Lex/PPLexerChange.cpp:299 + ? Twine{"#import \"" + RelativePath + "\"\n"}.str() + : Twine{"#include \"" + RelativePath + "\"\n"}.str(); + unsigned EndOffset = SourceMgr.getDecomposedLoc(EndLoc).second; ---------------- Is it possible to incorporate the string selection as part of the diagnostic description in the `.td` file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82118/new/ https://reviews.llvm.org/D82118 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits