rsandifo-arm added inline comments.

================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:748
+      llvm::DINodeArray SubscriptArray = DBuilder.getOrCreateArray(Subscript);
+      llvm::DIType *ElemTy =
+          getOrCreateType(Info.ElementType, TheCU->getFile());
----------------
I might be misreading the code, but if we're representing svbool_t as a bitmask 
(which is a good approach IMO), would it be better to pass UnsignedCharTy 
rather than BoolTy here?  It seems odd to represent the type as <vscale x 2> 
“bools”.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86101/new/

https://reviews.llvm.org/D86101

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to