chill added a comment. In D85649 <https://reviews.llvm.org/D85649> I suggested a different version of module flags, which is a bit nicer to use, e.g. one can say just
getModuleFlag("sign-return-address-with-bkey") != nullptr instead of a) checking for the flag presence, b) getting its value and c) comparing it to a set of strings, which is way too verbose. Thus, the set of module flags are essentially booleans: - "sign-return-address" when PAC-RET is enabled; it establishes the defaults of signing non-leaf functions with the A key - "sign-return-address-all", modifies the default, established by "sign-return-address" to signing all functions, including ones that do not spill LR - "sign-return-address-with-bkey", modifies the default, established by "sign-return-address" to signing with the B key. These are not ABI, so if, in the future, if we do need a set of values, we can easily change it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits