eduucaldas added a reviewer: gribozavr2.
eduucaldas added inline comments.

================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:506
 |     `-'~'
-|-'decltype'
+|-'decltype' OpenParen
 |-'('
----------------
This is wrong but it's just because decltype is all wrong


================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2734
+|   |   `-'args'
+|   `-'...'
+`-')' CloseParen
----------------
Here there is a divergence between the grammar and the ClangAST. 
According to the [[ https://eel.is/c++draft/expr.post#nt:expression-list | 
grammar ]]  `...` would an optional element of `CallArguments`, but here `...` 
is part of an expression.

Perhaps I have used the wrong kind of `...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86544/new/

https://reviews.llvm.org/D86544

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to