JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land.
The duplication from libc++ doesn't feel good but I can see how it happened. Dependency breaking etc. ================ Comment at: clang/lib/Headers/openmp_wrappers/complex_cmath.h:58 + +template <class _Tp> __DEVICE__ _Tp norm(const std::complex<_Tp> &__c) { + if (std::isinf(__c.real())) ---------------- Doesn't matter hugely given inlining, but I'm surprised to see std::complex taken by const & instead of by value. ================ Comment at: clang/test/Headers/Inputs/include/type_traits:3 + +#pragma once + ---------------- In order to run the tests without libc++/libstdc++ available? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits