ABataev added inline comments.
================ Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl<FunctionDecl *> &Bases); ---------------- JonChesterfield wrote: > SmallVectorImpl => SmallVector? It is a good practice to pass SmallVectors as SmallVectorImpl to make it independent of concrete SmallVector template specialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85735/new/ https://reviews.llvm.org/D85735 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits