LLVM_DUMP_METHOD is meant to be used for annotating functions that might be useful to execute from a debugger to dump data structures, etc - so it's expected that they'd be unused. Do you find that this function is not useful to use from a debugger/similar situation? (or perhaps because the function was "static" it was hitting a compiler warning/error & not actually being emitted into the resulting binary for use by an interactive debugger?)
+Kristof for comments/thoughts On Fri, Sep 11, 2020 at 4:50 PM Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Vitaly Buka > Date: 2020-09-11T16:50:30-07:00 > New Revision: a8503b87f739776cc9d5738f69aa0990db952340 > > URL: > https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340 > DIFF: > https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340.diff > > LOG: [NFC] Remove unused static function > > Added: > > > Modified: > clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp > > Removed: > > > > > ################################################################################ > diff --git a/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp > b/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp > index 441dcad42444..ce4addd2f945 100644 > --- a/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp > +++ b/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp > @@ -834,11 +834,6 @@ LLVM_DUMP_METHOD static void > dumpArgTokensToStream(llvm::raw_ostream &Out, > const Preprocessor &PP, > const ArgTokensTy > &Toks); > > -LLVM_DUMP_METHOD static void dumpArgTokens(const Preprocessor &PP, > - const ArgTokensTy &Toks) { > - dumpArgTokensToStream(llvm::errs(), PP, Toks); > -} > - > namespace { > /// Maps unexpanded macro parameters to expanded arguments. A macro > argument may > /// need to expanded further when it is nested inside another macro. > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
