aaron.ballman added inline comments.
================ Comment at: clang/include/clang/Basic/Attr.td:2123 + let Spellings = [GNU<"swift_bridged_typedef">]; + let Subjects = SubjectList<[TypedefName], ErrorDiag, "typedefs">; + let Documentation = [SwiftBridgedTypedefDocs]; ---------------- compnerd wrote: > aaron.ballman wrote: > > Does the default diagnostic text generate something bad that caused you to > > add `typedefs` here? > I don't remember, I'll double check. I noticed on a few other reviews that there was a field there, I wonder if the code originated before we added smarter logic for arbitrary subject lists. ================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7543 + case ParsedAttr::AT_SwiftBridgedTypedef: + handleSimpleAttribute<SwiftBridgedTypedefAttr>(S, D, AL); + break; ---------------- compnerd wrote: > aaron.ballman wrote: > > Should there be any type checking that the underlying type of the typedef > > is a sensible one to bridge? > I can't really think of anything that you could check that would be valuable. > What types of things were you thinking? I was mostly thinking about builtin types like `int`, but I don't insist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
