martong added a comment. > This problem only exists if we traverse a CFGBlock in order. And Liveness in > fact does it reverse order. So a distinct pass is indeed unnecessary, we can > note the appearance of the assignment by the time we reach the variable.
Should this patch depend on https://reviews.llvm.org/D87519? ================ Comment at: clang/include/clang/Analysis/CFG.h:1311 + + llvm::iterator_range<iterator> nodes() { return *this; } + llvm::iterator_range<const_iterator> const_nodes() const { return *this; } ---------------- Do we convert `this` to `CFGBlock *Entry` here? If yes, please comment it there in the code, so others should not be forced to dig up the first data member. (If no then this code is hard to understand.) Even better, why not `return *Entry`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87518/new/ https://reviews.llvm.org/D87518 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
