rsmith accepted this revision.
rsmith added a comment.
Thanks! This looks good to me (subject to Aaron's comment being addressed).
Please wait a couple of days for any more comments from the other reviewers.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:9689
+ Context.getTargetInfo().getCXXABI().isMicrosoft()) {
+ NewFD->addAttr(BuiltinAttr::CreateImplicit(Context, BuiltinID));
+ }
----------------
Please can you add a `// FIXME` here that we should probably only recognize
this as a builtin in the scope where the MS headers actually declare it, rather
than in every scope.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77491/new/
https://reviews.llvm.org/D77491
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
